gnodet commented on code in PR #1387:
URL: https://github.com/apache/maven/pull/1387#discussion_r1460663196
##########
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultProject.java:
##########
@@ -121,13 +134,12 @@ public boolean isExecutionRoot() {
@Override
public boolean isTopProject() {
- return getBasedir().isPresent()
- && getBasedir().get().equals(getSession().getTopDirectory());
+ return getBasedir().equals(getSession().getTopDirectory());
}
@Override
public boolean isRootProject() {
- return getBasedir().isPresent() &&
getBasedir().get().equals(getRootDirectory());
+ return getBasedir().equals(getRootDirectory());
Review Comment:
This will always be false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
