cstamas commented on code in PR #1387:
URL: https://github.com/apache/maven/pull/1387#discussion_r1459274418


##########
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##########
@@ -37,24 +37,58 @@
 @Experimental
 public interface Project {
 
+    /**
+     * Returns the project groupId.
+     */
     @Nonnull
     String getGroupId();
 
+    /**
+     * Returns the project artifactId.
+     */
     @Nonnull
     String getArtifactId();
 
+    /**
+     * Returns the project version.
+     */
     @Nonnull
     String getVersion();
 
+    /**
+     * Returns the project packaging.
+     */
     @Nonnull
     String getPackaging();
 
+    /**
+     * Returns the project artifact, that is the artifact produced by this 
project. If the artifact file exists, it is
+     * registered to {@link org.apache.maven.api.services.ArtifactManager}.
+     *
+     * @see org.apache.maven.api.services.ArtifactManager#getPath(Artifact)
+     */
     @Nonnull

Review Comment:
   This is "the" artifact that project produces (will install, deploy, 
whatever). IMHO, it should not tell that, and should remain agnostic to all 
those... IF someone wants POM artifact or BUILD artifact, then there is new 
method...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to