[ 
https://issues.apache.org/jira/browse/MNG-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808718#comment-17808718
 ] 

ASF GitHub Bot commented on MNG-8023:
-------------------------------------

michael-o commented on code in PR #1387:
URL: https://github.com/apache/maven/pull/1387#discussion_r1459257761


##########
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##########
@@ -73,9 +79,10 @@ public interface Project {
      * Returns the project artifacts, that is, the project POM artifact and 
the artifact produced by this project build.
      * The list may have one or two elements (never less than 1, never more 
than 2), depending on project packaging.
      * <p>
-     * The list 1st element is ALWAYS the project POM artifact. The existence 
of 2nd element depends on this project
-     * packaging.
+     * The list 1st element is ALWAYS the project POM artifact. Presence of 
2nd element in the list depends solely on

Review Comment:
   first



##########
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##########
@@ -73,9 +79,10 @@ public interface Project {
      * Returns the project artifacts, that is, the project POM artifact and 
the artifact produced by this project build.
      * The list may have one or two elements (never less than 1, never more 
than 2), depending on project packaging.
      * <p>
-     * The list 1st element is ALWAYS the project POM artifact. The existence 
of 2nd element depends on this project
-     * packaging.
+     * The list 1st element is ALWAYS the project POM artifact. Presence of 
2nd element in the list depends solely on

Review Comment:
   list's



##########
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##########
@@ -73,9 +79,10 @@ public interface Project {
      * Returns the project artifacts, that is, the project POM artifact and 
the artifact produced by this project build.
      * The list may have one or two elements (never less than 1, never more 
than 2), depending on project packaging.
      * <p>
-     * The list 1st element is ALWAYS the project POM artifact. The existence 
of 2nd element depends on this project
-     * packaging.
+     * The list 1st element is ALWAYS the project POM artifact. Presence of 
2nd element in the list depends solely on

Review Comment:
   second





> New method for project artifacts
> --------------------------------
>
>                 Key: MNG-8023
>                 URL: https://issues.apache.org/jira/browse/MNG-8023
>             Project: Maven
>          Issue Type: Task
>          Components: API
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Introduce a new method on API Project object that exposes "main artifacts" of 
> project. The method can return 1 or 2 artifacts (never less than 1 and never 
> more than 2). These are NOT the attached artifacts! (see ProjectManager for 
> that).
> In short: projects with packaging "pom", "bom" will on this method return 1 
> artifact, while projects with packaging "jar" will return 2 artifacts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to