gnodet commented on code in PR #39:
URL:
https://github.com/apache/maven-plugin-testing/pull/39#discussion_r1453106042
##########
maven-plugin-testing-harness/pom.xml:
##########
@@ -74,6 +80,15 @@ under the License.
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-xml-impl</artifactId>
+ <version>${mavenVersion}</version>
Review Comment:
Is that necessary ? We're running unit tests here, this is not a dependency
of a plugin which runs in Maven. Having this dependency optional or provided
means that all plugins will have to add a dependency to it in order to execute
their unit tests, isn't it ?
I wonder if we should split this library in two separate modules, one for
Maven 3 and another one for Maven 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
