judovana commented on PR #28:
URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-1891540458
I still think the
```
<maven.compiler.source>${javaCompilerVersionLocal}</maven.compiler.source>
<maven.compiler.target>${javaCompilerVersionLocal}</maven.compiler.target>
+ <!--maven.compiler.target>11</maven.compiler.target-->
```
is misplaced, and should be at
https://github.com/apache/maven-archetypes/blob/master/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L49
Generally I think this commit is not helpful, as it will just confuse any
future grep/sed and generally any maven user/java developer should be able to
bump 8 to 11, or generally to anything they need.
I had missed reasoning why you actually proposed this changeset.
Thanx for merging #27 . As for this, I'm -1, but I do not have any
permissions of any weight :) Good luck!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
