kwin commented on code in PR #195:
URL: https://github.com/apache/maven-doxia/pull/195#discussion_r1451704784
##########
doxia-core/src/main/java/org/apache/maven/doxia/parser/Parser.java:
##########
@@ -95,11 +95,12 @@ public interface Parser {
void addSinkWrapperFactory(SinkWrapperFactory factory);
/**
- *
- * @return all sink wrapper factories in the correct order (both
registered automatically and manually)
+ * Returns all sink wrapper factories (both registered automatically and
manually). The collection is ordered in a way that
+ * the factories having the lowest priority come first (i.e. in reverse
order).
+ * @return all sink wrapper factories in the reverse order
* @since 2.0.0
*/
- Collection<SinkWrapperFactory> getSinkWrapperFactories();
+ List<SinkWrapperFactory> getSinkWrapperFactories();
Review Comment:
I think it was a mistake exposing that via `Parser`. This is clearly SPI
only and therefore only belongs to `AbstractParser`. There it should be a
protected method. `List` as return value makes sense for usages which try to
retrieve the last element only. For me M-builds should allow to modify API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
