[
https://issues.apache.org/jira/browse/MINSTALL-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805946#comment-17805946
]
ASF GitHub Bot commented on MINSTALL-197:
-----------------------------------------
michael-o commented on code in PR #61:
URL:
https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450084824
##########
src/test/java/org/apache/maven/plugins/install/stubs/InstallArtifactStub.java:
##########
@@ -85,8 +85,8 @@ public void addMetadata(ArtifactMetadata metadata) {
}
}
- public Collection getMetadataList() {
- return metadataMap == null ? Collections.EMPTY_LIST :
metadataMap.values();
+ public Collection<ArtifactMetadata> getMetadataList() {
+ return metadataMap == null ? Collections.emptyList() :
metadataMap.values();
Review Comment:
Isn*t this inconsistent? One is writable, the other one not?
> Upgrade parent to 41, remove deprecations
> -----------------------------------------
>
> Key: MINSTALL-197
> URL: https://issues.apache.org/jira/browse/MINSTALL-197
> Project: Maven Install Plugin
> Issue Type: Task
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 3.1.2
>
>
> Upgrade parent to 41, remove deprecations
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
