ceki commented on code in PR #1358:
URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681
##########
pom.xml:
##########
@@ -180,7 +180,8 @@ under the License.
<resolverVersion>2.0.0-alpha-5</resolverVersion>
<securityDispatcherVersion>2.0</securityDispatcherVersion>
<sisuVersion>0.9.0.M2</sisuVersion>
- <slf4jVersion>1.7.36</slf4jVersion>
+ <slf4jVersion>2.0.9</slf4jVersion>
+ <slf4jSimpleVersion>1.7.36</slf4jSimpleVersion>
Review Comment:
> do you think this commit
https://github.com/qos-ch/slf4j/commit/509c3444ac7 could be backported to slf4j
2.x ?
@gnodet Yes, of course.
Compared to the code in 2.0, it looks like only the `renderLevel` method was
missing. I added it back in commit [7029a8b7fda
](https://github.com/qos-ch/slf4j/commit/7029a8b7fda826f425c740a847e97f4c0a063dbe)
in the main branch (i.e the 2.0 branch). This should hopefully allow you to
move to slf4j-simple version 2.0.
Let me know if other changes are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
