[ 
https://issues.apache.org/jira/browse/MNG-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804246#comment-17804246
 ] 

ASF GitHub Bot commented on MNG-7173:
-------------------------------------

cstamas commented on PR #479:
URL: https://github.com/apache/maven/pull/479#issuecomment-1880864067

   This PR is defunct, Guice modules were removed in 
https://github.com/apache/maven/pull/1282




> MavenResolverModule is broken/incomplete
> ----------------------------------------
>
>                 Key: MNG-7173
>                 URL: https://issues.apache.org/jira/browse/MNG-7173
>             Project: Maven
>          Issue Type: Task
>            Reporter: Tamas Cservenak
>            Priority: Major
>
> TheĀ MavenResolverModule is broken/incomplete since 3.6.2 (or 3.6.3). But as 
> we have no tests for it, this went completely unnoticed and is seen by 
> downstream clients only.
> In maven-resolver-provider we need to:
> a) fix theĀ MavenResolverModule, make it complete (related to ModelBuilder 
> deps)
> b) add tests to ensure it is "complete"
> Note: maven-resolver demo snippets for guice, while usedĀ MavenResolverModule, 
> is and never will be in "lockstep", it used 3.5.0 of it, hence, the changes 
> in 3.6.2 were missed by it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to