[
https://issues.apache.org/jira/browse/DOXIA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803669#comment-17803669
]
ASF GitHub Bot commented on DOXIA-695:
--------------------------------------
michael-o commented on code in PR #193:
URL: https://github.com/apache/maven-doxia/pull/193#discussion_r1443255958
##########
doxia-modules/doxia-module-apt/src/test/java/org/apache/maven/doxia/module/apt/AptSinkTest.java:
##########
@@ -126,6 +126,11 @@ protected String getSection5Block(String title) {
return EOL + StringUtils.repeat(AptMarkup.SECTION_TITLE_START_MARKUP,
4) + title + EOL + EOL + EOL;
}
+ /** {@inheritDoc} */
+ protected String getSection6Block(String title) {
+ return EOL + StringUtils.repeat(AptMarkup.SECTION_TITLE_START_MARKUP,
4) + title + EOL + EOL + EOL;
Review Comment:
4, not 5?
##########
doxia-modules/doxia-module-xhtml5/src/main/java/org/apache/maven/doxia/module/xhtml5/Xhtml5Parser.java:
##########
@@ -158,7 +158,7 @@ protected void handleEndTag(XmlPullParser parser, Sink sink)
} else if (parser.getName().equals(TITLE.toString())) {
sink.title_();
} else if (parser.getName().equals(BODY.toString())) {
- consecutiveSections(0, sink, null);
+ emitHeadingSections(0, sink, false);
Review Comment:
This one confuses me
> Support of h6 in xhtml output is broken
> ---------------------------------------
>
> Key: DOXIA-695
> URL: https://issues.apache.org/jira/browse/DOXIA-695
> Project: Maven Doxia
> Issue Type: Bug
> Components: Modules, Sink API
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> It seems that due to
> [https://github.com/apache/maven-doxia/commit/87d1ab3979d9df3f6c9af2b2c9bb3baf4152d8b1]
> the support for headings on level 6 has been completely dropped, e.g. the
> heading from
> https://github.com/apache/maven-site/blob/f8579f4f91aa826501528b64a7c6baadf6492986/content/markdown/guides/mini/guide-configuring-plugins.md?plain=1#L284
> is valid in markdown but is incorrectly rendered as regular paragraph in
> [https://maven.apache.org/guides/mini/guide-configuring-plugins.html.]
> As (X)HTML defines headings from level 1 - 6 (as well as markdown, see
> [https://daringfireball.net/projects/markdown/syntax#header]) I guess the
> sink needs new methods for dealing with a 6th section. The restriction to 5
> sections in the Sink API seems to stem from APT which only supports 5 levels
> ([https://maven.apache.org/doxia/references/apt-format.html#section])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
