judovana commented on code in PR #26: URL: https://github.com/apache/maven-archetypes/pull/26#discussion_r1440165609
########## maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml: ########## @@ -1,11 +1,11 @@ <?xml version="1.0" encoding="UTF-8"?> -#macro( compilerProperties $javaCompilerVersion ) +#macro( compilerProperties $javaCompilerVersionLocal ) Review Comment: no. TL/DR, yes and no,which was the reasoning of the PR. javaCompilerVersion is a property which can (and should) be used to set desired bytecode version, however in maven-archetype-quickstart it is partially broken (https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-77) . In the line of question, however it is not the variable, but it's macro-local copy. See the calls: https://github.com/apache/maven-archetypes/blob/bb9279764c5417042daf1eda8f10842a0a5bbf29/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L49 and https://github.com/apache/maven-archetypes/blob/bb9279764c5417042daf1eda8f10842a0a5bbf29/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L51 When I was trying to fix the https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-77, this local occurrence was still meddling in. Note, that this PR suggest two names. I prefer the one ion first commit, but the second is probably better. I'm ok with any name you would be happy with. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
