[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801324#comment-17801324
]
ASF GitHub Bot commented on DOXIA-716:
--------------------------------------
kwin commented on code in PR #187:
URL: https://github.com/apache/maven-doxia/pull/187#discussion_r1438543745
##########
doxia-core/src/test/java/org/apache/maven/doxia/xsd/AbstractXmlValidator.java:
##########
@@ -157,8 +161,17 @@ protected void setValidate(boolean validate) {
private XMLReader getXMLReader() {
if (xmlReader == null) {
try {
- xmlReader =
XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
+ SAXParserFactory parserFactory =
SAXParserFactory.newInstance();
Review Comment:
Is it possible to shared the same method in AbstractXmlValidator and
XmlValidator somehow? It seems the same features need to be enabled here.
> Update and unify XMLReader creation and configuration
> -----------------------------------------------------
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M8
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
