michael-o commented on PR #670: URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1868376997
I have now re-read the code and your change. I fail to see how this change only applies to successful tests. It applies to *all* type of results: `SUCCESS` and non-`SUCCESS` otherwise you wouldn't modify `#getTestProblems()`, no? This is no not necessarily wrong, but inconsistent with your description. See the original change: https://github.com/apache/maven-surefire/commit/b80325616daa323eb71a04a61d7485a1d303230c#diff-c634b539151b4b76bde50d93d5a6cd2b0f51aa411281398cc295cc721bdfa1d5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
