judovana commented on code in PR #22:
URL: https://github.com/apache/maven-archetypes/pull/22#discussion_r1434949427


##########
.github/workflows/maven-verify.yml:
##########
@@ -25,3 +25,5 @@ jobs:
   build:
     name: Verify
     uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v3
+    with:
+      jdk-matrix: '[ "8", "11", "17", "21" ]'

Review Comment:
   Sure it is. And I agree wiht it. But not in the way you did it.
   You had mixed three parts in one PR I do not understand why. This should be 
separate PR, whcihshoudl go in before 
https://github.com/apache/maven-archetypes/pull/20
   
   Aslo you are reverting the change which was agreed during review of #18



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to