[
https://issues.apache.org/jira/browse/SUREFIRE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799624#comment-17799624
]
ASF GitHub Bot commented on SUREFIRE-2224:
------------------------------------------
kriegaex commented on PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#issuecomment-1867103417
@michael-o, actually, I am a bit out of context here and not 100% sure what
that code does and currently am busy otherwise, i.e. I am just looking at the
code here on the website, which IMO is **not** a good way to conduct a proper
review. You have to check out the code and see what it does, inspect/run tests
covering the code etc.
It looks as if in case of reported test errors or failures, it adds
something like an "error" or "failure" tag to the XML and then, if any stack
trace exists, also a "stackTrace" element and "system-out"/"system-err".
Am I seeing correctly, that you just refactored the code with no functional
changes, only reflecting the nesting structure of the XML output in the logical
structure (`if` block) of the source code? If so, it looks good to me.
> StatelessXmlReporter#getTestProblems() does not properly reflect report
> schema structure
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-2224
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2224
> Project: Maven Surefire
> Issue Type: Bug
> Components: xml generation
> Affects Versions: 3.2.3
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.2.4
>
>
> According to
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> not all nested elements contain {{stackTrace}}, {{system-out}} and
> {{system-err}} elements, but the code makes it conditional whether there is a
> stack trace or not. This does not comply with the schema definition. Either
> the nested element is simple content or complex. In the latter {{stackTrace}}
> is mandatory, even if there is no strack trace according to the schema. The
> system streams are optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
