cstamas commented on PR #1337: URL: https://github.com/apache/maven/pull/1337#issuecomment-1859921082
I agree with https://github.com/apache/maven/pull/1337/commits/49cec292edce1b8aeb5d8f54a7e729ad70f00a5b commit: if component changed so session scope, no need for provider. But I don't understand 2nd commit https://github.com/apache/maven/pull/1337/commits/5ce52798bea3c990bd407ef3b6cf2e5b6000e7fd that left components singletons, but you removed the provider. Can you explain that? As your 2nd commit makes mandatory to rebuild component graph in case of schema change, while with provider it was possible without doing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
