[ https://issues.apache.org/jira/browse/MNG-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798084#comment-17798084 ]
ASF GitHub Bot commented on MNG-7951: ------------------------------------- cstamas commented on PR #1337: URL: https://github.com/apache/maven/pull/1337#issuecomment-1859921082 I agree with https://github.com/apache/maven/pull/1337/commits/49cec292edce1b8aeb5d8f54a7e729ad70f00a5b commit: if component changed so session scope, no need for provider. But I don't understand 2nd commit https://github.com/apache/maven/pull/1337/commits/5ce52798bea3c990bd407ef3b6cf2e5b6000e7fd that left components singletons, but you removed the provider. Can you explain that? As your 2nd commit makes mandatory to rebuild component graph in case of schema change, while with provider it was possible without doing that. > Change resolver provider components to accept version scheme provider > --------------------------------------------------------------------- > > Key: MNG-7951 > URL: https://issues.apache.org/jira/browse/MNG-7951 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories > Reporter: Tamas Cservenak > Assignee: Tamas Cservenak > Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-10 > > > -Resolver implemented MRESOLVER-446 and there is one component in > maven-resolver-provider that needs change to have Maven fully support > per-session VersionScheme. Also we should look for any other possible spots > as well...- > This also follows up on MNG-7103 > Long term plan: allow us to kill off Maven Version implementations, possibly > reimplementing it as resolver' VersionScheme (it is nicely UT covered) with > all it's flaws, and then have explicit switch between "legacy" (Maven > Version) and "generic" (Resolver) version scheme, or maybe even have some new > future schemes as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)