cstamas commented on code in PR #1347:
URL: https://github.com/apache/maven/pull/1347#discussion_r1429763979


##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/ArtifactCoordinateFactory.java:
##########
@@ -43,6 +43,18 @@ public interface ArtifactCoordinateFactory extends Service {
     @Nonnull
     ArtifactCoordinate create(@Nonnull ArtifactCoordinateFactoryRequest 
request);
 
+    /**
+     * Creates a coordinate out of string that is formatted like:
+     * {@code <groupId>:<artifactId>[:<extension>[:<classifier>]]:<version>}
+     *
+     * @param session the session.
+     * @param coordinateString the string having "standard" coordinate.
+     * @return an {@code Artifact}, never {@code null}
+     * @throws IllegalArgumentException if {@code request} is null or {@code 
request.session} is null or invalid
+     */
+    @Nonnull
+    ArtifactCoordinate create(@Nonnull Session session, @Nonnull String 
coordinateString);

Review Comment:
   moved stuff into request



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to