[ 
https://issues.apache.org/jira/browse/MNG-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798049#comment-17798049
 ] 

ASF GitHub Bot commented on MNG-7968:
-------------------------------------

cstamas commented on code in PR #1346:
URL: https://github.com/apache/maven/pull/1346#discussion_r1429719846


##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/RuntimeInformation.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import org.apache.maven.api.Service;
+import org.apache.maven.api.Version;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+
+/**
+ * Service interface to provide runtime information.
+ *
+ * @since 4.0.0
+ */
+@Experimental
+public interface RuntimeInformation extends Service {
+
+    /**
+     * Returns the "runtime version", Maven version caller runs in.
+     *
+     * @return the runtime version, never {@code null}
+     */
+    @Nonnull
+    Version runtimeVersion();

Review Comment:
   Will drop this and make `Session.getMavenVersion()` return a `Version`, as 
the most cases RT version is needed is:
   * display purposes (asString() is there)
   * compare/range check, and Version is needed for that
   
   Having `Session.getMavenVersion()` return plain String is ok for 1st but not 
enough for 2nd use case.





> Maven RT Service equivalent for RuntimeInformation
> --------------------------------------------------
>
>                 Key: MNG-7968
>                 URL: https://issues.apache.org/jira/browse/MNG-7968
>             Project: Maven
>          Issue Type: Task
>          Components: Core
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Equivalent service for org.apache.maven.rtinfo.RuntimeInformation to reveal 
> "runtime Maven Version" for those who needs it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to