[
https://issues.apache.org/jira/browse/MNG-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798035#comment-17798035
]
ASF GitHub Bot commented on MNG-7972:
-------------------------------------
gnodet commented on code in PR #1347:
URL: https://github.com/apache/maven/pull/1347#discussion_r1429589638
##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/ArtifactCoordinateFactory.java:
##########
@@ -43,6 +43,18 @@ public interface ArtifactCoordinateFactory extends Service {
@Nonnull
ArtifactCoordinate create(@Nonnull ArtifactCoordinateFactoryRequest
request);
+ /**
+ * Creates a coordinate out of string that is formatted like:
+ * {@code <groupId>:<artifactId>[:<extension>[:<classifier>]]:<version>}
+ *
+ * @param session the session.
+ * @param coordinateString the string having "standard" coordinate.
+ * @return an {@code Artifact}, never {@code null}
+ * @throws IllegalArgumentException if {@code request} is null or {@code
request.session} is null or invalid
+ */
+ @Nonnull
+ ArtifactCoordinate create(@Nonnull Session session, @Nonnull String
coordinateString);
Review Comment:
In other services, when multiple "signatures" are involved, a single
"request" object is used to store all those bits. I'm not sure why we should
not do the same here, i.e. add a `coordinateString` member to the
`ArtifactCoordinateRequest`.
> Artifact creation from "standard string"
> ----------------------------------------
>
> Key: MNG-7972
> URL: https://issues.apache.org/jira/browse/MNG-7972
> Project: Maven
> Issue Type: Task
> Components: Core
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Expose API to create artifact from "standard string":
> {noformat}
> <groupId>:<artifactId>[:<extension>[:<classifier>]]:<version>{noformat}
> As currently there is none for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
