[
https://issues.apache.org/jira/browse/DOXIA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797492#comment-17797492
]
ASF GitHub Bot commented on DOXIA-710:
--------------------------------------
michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428911493
##########
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java:
##########
@@ -304,7 +310,7 @@ public String toString(int depth) {
message.append(", title: ").append(title);
}
- message.append(EOL);
+ message.append(System.lineSeparator());
Review Comment:
Attention, this is a semantical change. All others use the idiom above and
there are tests which change the separator with try/finally. This one is caches
upon first call. I wouldn't change it.
> Inconsistent anchors between toc macro and headers
> --------------------------------------------------
>
> Key: DOXIA-710
> URL: https://issues.apache.org/jira/browse/DOXIA-710
> Project: Maven Doxia
> Issue Type: Bug
> Reporter: Slawomir Jaranowski
> Assignee: Konrad Windszus
> Priority: Critical
>
> In markdown document add:
> {code:java}
> <!-- MACRO{toc|fromDepth=2} -->
> {code}
> Then anchors generated by toc macro looks like: {{#Your_First_Mojo}}
> and anchors generated by skin looks like: {{#your-first-plugin}}
> - Doxia Site Renderer 2.0.0-M4
> - Fluido Skin 1.11.1
> Tested on Maven main site without more investigate.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
