michael-o commented on code in PR #182:
URL: https://github.com/apache/maven-doxia/pull/182#discussion_r1427007175
##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractSink.java:
##########
@@ -23,12 +23,337 @@
/**
* An abstract base class that defines some convenience methods for sinks.
+ * Also acts as compatibility bridge for Doxia 1.0 methods which have
overridden variants in Doxia > 1.0
Review Comment:
So this is temporary?
##########
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/SinkEventTestingSink.java:
##########
@@ -803,11 +488,6 @@ public void division(SinkEventAttributes attributes) {
addEvent("division", new Object[] {attributes});
}
- @Override
- public void verbatim() {
- addEvent("verbatim");
- }
-
@Override
public void verbatim(SinkEventAttributes attributes) {
addEvent("verbatim", new Object[] {attributes});
Review Comment:
These changes I do not fully understand. Now the events are gone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
