[
https://issues.apache.org/jira/browse/MNG-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796673#comment-17796673
]
ASF GitHub Bot commented on MNG-7963:
-------------------------------------
cstamas commented on code in PR #1340:
URL: https://github.com/apache/maven/pull/1340#discussion_r1426570213
##########
maven-embedder/src/main/java/org/eclipse/sisu/plexus/PlexusXmlBeanConverter.java:
##########
@@ -43,6 +42,7 @@
import org.codehaus.plexus.util.xml.pull.MXParser;
import org.codehaus.plexus.util.xml.pull.XmlPullParser;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.sisu.Priority;
Review Comment:
Historically, Sisu relied on JSR250 and alike annotations, but as time
passed, it implemented more and more of "own" annotations. Since a while (0.3.4
or so) it has it all in own namespace as well. If you look at history of this
PR, you will see that I even removed `java.annotations:javax.annotations-api`
from Maven completely, and Maven has happy about it, but we have one IT that
uses it, the MavenITmng6084Jsr250PluginTest, hence I had to undo that change.
Given Sisu is "internal implementation detail" of Maven Core, I think using
Sisu annotations _within_ Maven core is best/better, than relying on something
else.
So this PR just makes sure that Maven Core uses Sisu annotations instead of
something else, while the semantics 100% remains same as test/ITs prove.
> Clean up the build, tidy up dependencies
> ----------------------------------------
>
> Key: MNG-7963
> URL: https://issues.apache.org/jira/browse/MNG-7963
> Project: Maven
> Issue Type: Task
> Components: Bootstrap & Build
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Currently the build is ok, but contains many redundant elements in POM,
> repetitions and badly scoped dependencies.
> This change is NOT about upgrading any dependency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
