[
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795834#comment-17795834
]
ASF GitHub Bot commented on SUREFIRE-1345:
------------------------------------------
gsmet opened a new pull request, #700:
URL: https://github.com/apache/maven-surefire/pull/700
Hey there,
In the Quarkus project, we make good use of the Surefire reports to provide
a full report of a pull request run.
We will soon enable the ability to retry tests but we need to make sure we
can easily identify flaky tests thus why we included the ability to get
flakyFailures and flakyErrors from the report.
This is related to https://issues.apache.org/jira/browse/SUREFIRE-1345 but
does not entirely implement it as I haven't implemented the reruns. I could be
convinced to if you think it's crucial to get this PR in but, in our case, we
don't see it as useful.
Tests are included to make sure the data is properly extracted.
I think I already signed the Apache CLA a long time ago but can fill it
again if needed.
Happy to iterate on this to get it merged soon.
Thanks for having a look!
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Report parser doesn't support flaky and retries
> -----------------------------------------------
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
> Issue Type: Bug
> Reporter: Dmitry Baev
> Priority: Major
>
> TestSuiteXmlParser (from
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
