elharo commented on code in PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420388359
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -321,19 +347,20 @@ public void filterResources(MavenResourcesExecution
mavenResourcesExecution) thr
}
/**
- * Get the encoding to use when filtering the specified file. Properties
files can be configured to use a different
- * encoding than regular files.
+ * Get the encoding to use when filtering the specified file. Properties
files
+ * can be configured to use a different encoding than regular files.
*
- * @param file The file to check
- * @param encoding The encoding to use for regular files
+ * @param file The file to check
Review Comment:
Probably better not to try to line these up. It's too hard to maintain.
But we should make the initial letter lower case in keeping with Oracle
guideline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
