jorsol commented on PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#issuecomment-1843931085
> > Well, I think this should be ready to be merged if there is no other comment. > > BTW, looking at the open issues, this should also fix [MCOMPILER-333](https://issues.apache.org/jira/browse/MCOMPILER-333) so it can be linked to this and declare it fixed for 3.12.0 > > it's usually better to have a PR per change, especially in case of non-related changes. But as you already hijacked this PR #186 here, it would be good to have this in the PR title and commits for history. And obviously, update https://issues.apache.org/jira/browse/MCOMPILER-333 Sure, will create a new PR for that change. the fix is simpler than the one from #186. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
