[
https://issues.apache.org/jira/browse/SUREFIRE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792852#comment-17792852
]
ASF GitHub Bot commented on SUREFIRE-1934:
------------------------------------------
michael-o commented on code in PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#discussion_r1413880902
##########
surefire-its/src/test/resources/surefire-1934-enable-out-elements/pom.xml:
##########
@@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.maven.surefire</groupId>
+ <artifactId>it-parent</artifactId>
+ <version>1.0</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-1934-disable-out-elements</artifactId>
+ <version>1.0</version>
+ <url>http://maven.apache.org</url>
+
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.0</version>
+ </dependency>
+ <dependency>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ <version>1.2.16</version>
+ </dependency>
+ </dependencies>
Review Comment:
Can you please swap this for SLF4J API + Simple. Log4J is a troublesome
fellow.
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -679,6 +679,16 @@ public abstract class AbstractSurefireMojo extends
AbstractMojo implements Suref
@Parameter(property = "enableAssertions", defaultValue = "true")
private boolean enableAssertions;
+ /**
+ * Flag for including/excluding system-out and system-err elements in xml
reports.
+ * <br>
+ * True by default.
Review Comment:
These two lines are redundant, Plugin Tools will take care of that.
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -679,6 +679,16 @@ public abstract class AbstractSurefireMojo extends
AbstractMojo implements Suref
@Parameter(property = "enableAssertions", defaultValue = "true")
private boolean enableAssertions;
+ /**
+ * Flag for including/excluding system-out and system-err elements in xml
reports.
+ * <br>
+ * True by default.
+ *
+ * @since 3.0.0
Review Comment:
This should be 3.2.3
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -679,6 +679,16 @@ public abstract class AbstractSurefireMojo extends
AbstractMojo implements Suref
@Parameter(property = "enableAssertions", defaultValue = "true")
private boolean enableAssertions;
+ /**
+ * Flag for including/excluding system-out and system-err elements in xml
reports.
Review Comment:
XML
> Ability to disable system-out/system-err for successfuly passed tests
> ---------------------------------------------------------------------
>
> Key: SUREFIRE-1934
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1934
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Plugin
> Affects Versions: 3.0.0-M5
> Reporter: Andrey Turbanov
> Priority: Major
>
> After SUREFIRE-1744 surefire-plugin always reports system-out/system-err even
> for successfully passed test. A lot of old projects with big amount of tests
> now have to deal with huge output.
> I think there should be option to disable new behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
