[
https://issues.apache.org/jira/browse/SUREFIRE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790455#comment-17790455
]
ASF GitHub Bot commented on SUREFIRE-2211:
------------------------------------------
michael-o commented on code in PR #689:
URL: https://github.com/apache/maven-surefire/pull/689#discussion_r1403697890
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java:
##########
@@ -179,6 +179,10 @@ static String relativize(@Nonnull Path parent, @Nonnull
Path child) throws Illeg
}
static String toAbsoluteUri(@Nonnull Path absolutePath) {
+ // unc paths needs to be written as file:////
+ if (absolutePath.toString().startsWith("\\\\")) {
+ return absolutePath.toFile().toURI().toASCIIString();
+ }
Review Comment:
That looks so sick...it should be identical. It this really so broken in
Java?
> additionalClasspathElement with UNC path not working with failsafe > 3.0.0-M1
> -----------------------------------------------------------------------------
>
> Key: SUREFIRE-2211
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2211
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
> Affects Versions: 3.0.0-M2, 3.2.2
> Environment: Windows JDK17.0.5+8
> Reporter: Robert Seidel
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.2.3
>
>
> We are using the configuration parameter additionalClasspathElements
> (https://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#additionalClasspathElements)
> to provide a log4j2 xml configuration during tests. There is configured an
> UNC path like this //our-server/build/failsafe containing the file.
> Until version 3.0.0-M2 everything was fine, the ressource could be found
> within the class loader and log4j was configured correctly (so 3.0.0-M1 was
> ok).
> However since the Milestone 2 of version 3 and with all later versions, the
> ressource could not be found within the classpath, leaving log4j unconfigured.
> From the reporting xml the classpath is configured the same, but the class
> loader behaves differently.
> When using a normal path like c:/build/failsafe the ressource can be found
> without issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
