slawekjaranowski commented on code in PR #173:
URL:
https://github.com/apache/maven-apache-parent/pull/173#discussion_r1374144851
##########
pom.xml:
##########
@@ -181,6 +182,11 @@ under the License.
<artifactId>maven-clean-plugin</artifactId>
<version>${version.maven-clean-plugin}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${version.maven-checkstyle-plugin}</version>
+ </plugin>
Review Comment:
yes it is true.
But newer checkstyle required JDK 11+, so in this place we can not make such
assumptions.
child project also define specific plugin configurations.
So here only plugin version is reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
