elharo commented on code in PR #78:
URL: https://github.com/apache/maven-filtering/pull/78#discussion_r1367902013
##########
src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java:
##########
@@ -171,4 +176,48 @@ private void assertWarn(Logger mock, String... expected) {
assertTrue(messages.contains(str));
}
}
+
+ public void testNonCircularReferences1Var3Times() throws IOException {
+ File basicProp = new File(testDirectory, "non-circular.properties");
+
+ if (basicProp.exists()) {
+ basicProp.delete();
+ }
+
+ basicProp.createNewFile();
+ try (FileWriter writer = new FileWriter(basicProp)) {
Review Comment:
try to avoid assuming the default character encoding; e.g. by using an
OutputStreamWriter directly inztead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
