slawekjaranowski commented on code in PR #1293:
URL: https://github.com/apache/maven/pull/1293#discussion_r1366055366


##########
maven-model/src/main/java/org/apache/maven/model/io/xpp3/MavenXpp3Reader.java:
##########
@@ -48,105 +52,99 @@ public MavenXpp3Reader(ContentTransformer 
contentTransformer) {
      * @return boolean
      */
     public boolean getAddDefaultEntities() {
-        return addDefaultEntities;
+        return delegate.getAddDefaultEntities();
     } // -- boolean getAddDefaultEntities()
 
+    /**
+     * Sets the state of the "add default entities" flag.
+     *
+     * @param addDefaultEntities a addDefaultEntities object.
+     */
+    public void setAddDefaultEntities(boolean addDefaultEntities) {
+        delegate.setAddLocationInformation(addDefaultEntities);
+    } // -- void setAddDefaultEntities( boolean )
+
+    protected Model read(Reader reader, boolean strict, InputSource source) 
throws IOException, XmlPullParserException {
+        try {
+            org.apache.maven.api.model.Model model = delegate.read(
+                    reader,
+                    strict,
+                    source != null
+                            ? new 
org.apache.maven.api.model.InputSource(source.getModelId(), 
source.getLocation())

Review Comment:
   `source.toApiSource()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to