[
https://issues.apache.org/jira/browse/MSHARED-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772802#comment-17772802
]
ASF GitHub Bot commented on MSHARED-1314:
-----------------------------------------
michael-o commented on code in PR #24:
URL:
https://github.com/apache/maven-reporting-impl/pull/24#discussion_r1349508543
##########
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##########
@@ -179,12 +179,14 @@ public abstract class AbstractMavenReport extends
AbstractMojo implements MavenM
/**
* This method is called when the report generation is invoked directly as
a standalone Mojo.
+ * This implementation is now marked {@code final} as it is not expected
to be overridden:
+ * {@code maven-reporting-impl} provides that plumbing.
Review Comment:
...provides all necessary plumbing.
##########
src/site/apt/index.apt.vm:
##########
@@ -38,10 +38,13 @@ ${project.name}
[]
+ The 2 APIs implementations are provided by
<<<{{{./apidocs/org/apache/maven/reporting/AbstractMavenReport.html}AbstractMavenReport}},
Review Comment:
The two API implementations...
> mark execute() final to avoid users extending reporting-impl implementation
> ---------------------------------------------------------------------------
>
> Key: MSHARED-1314
> URL: https://issues.apache.org/jira/browse/MSHARED-1314
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
> Affects Versions: maven-reporting-impl-4.0.0-M10
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Priority: Major
>
> see https://lists.apache.org/thread/mcbh55967j79dpv72tqnoqgowxhgvoj6
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
