[
https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771350#comment-17771350
]
ASF GitHub Bot commented on MBUILDCACHE-64:
-------------------------------------------
kbuntrock commented on PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1744305773
Re-opening the PR for merge.
It's now a mix between the very first implementation and the one with globs,
and it's combining better with the input section mechanism.
I feel much more at ease with this version. We can use only path
declaration, only glob declaration, or combine both if we want the best
trade-off between performances and functionalities.
Here a small list of improvements:
- the glob interpretation can be configured to better handle any specific
case (= less code to handle the specific cases ... :p )
- easier to test the exclusion mechanism with a unit test (added one)
- unit + IT test about unix/dos path style (and tested on Windows and Debian)
Here is the documentation presenting it :
And the updated "project property" page.
Looking forward to your feedbacks. :)
Especially in the project property section, I'm undecided about the naming
of the exclusion value : "maven.build.cache.exclude.value.my-exclusion" versus
"maven.build.cache.exclude.my-exclusion". (currently the first option, simpler
syntax / readability with the additional properties like
"maven.build.cache.exclude.glob.my-exclusion")
> Apply global exclusions to folder names
> ---------------------------------------
>
> Key: MBUILDCACHE-64
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-64
> Project: Maven Build Cache Extension
> Issue Type: Bug
> Affects Versions: 1.0.1
> Reporter: Frank Wagner
> Assignee: Olivier Lamy
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.1.0
>
>
> It is currently not possible to exclude folders by their name, like
> {quote}<input>
> <global>
> <excludes>
> <exclude>node_modules</exclude>
> <exclude>dist</exclude>
> <exclude>build</exclude>
> </excludes>
> </global>
> ...
> {quote}
> That's because isFilteredOutSubpath(),
> [https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L638,]
> uses startWith on normalized absolute paths.
> That function could be enhanced with an additional criterion like in
> [https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L510]
> {{filteredOutPaths.stream().anyMatch(it ->
> it.getFileName().equals(entry.getFileName()))}}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
