kbuntrock commented on PR #91:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1744305773

   Re-opening the PR for merge.
   
   It's now a mix between the very first implementation and the one with globs, 
and it's combining better with the input section mechanism. 
   
   I feel much more at ease with this version. We can use only path 
declaration, only glob declaration, or combine both if we want the best 
trade-off between performances and functionalities. 
   
   Here a small list of improvements: 
   - the glob interpretation can be configured to better handle any specific 
case (= less code to handle the specific cases ... :p )
   - easier to test the exclusion mechanism with a unit test (added one)
   - unit + IT test about unix/dos path style (and tested on Windows and Debian)
   
   Here is the documentation presenting it : 
   
   
![image](https://github.com/apache/maven-build-cache-extension/assets/15209500/e4690d41-3a6f-45b6-ace0-2c78606408f4)
   
   And the updated "project property" page.
   
   
![image](https://github.com/apache/maven-build-cache-extension/assets/15209500/604a5614-c3a4-4b30-8796-e770e6faed93)
   
   Looking forward to your feedbacks. :) 
   
   Especially in the project property section, I'm undecided about the naming 
of the exclusion value : "maven.build.cache.exclude.value.my-exclusion" versus 
"maven.build.cache.exclude.my-exclusion". (currently the first option, simpler 
syntax / readability with the additional properties like 
"maven.build.cache.exclude.glob.my-exclusion")


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to