chadwick00 commented on code in PR #218:
URL:
https://github.com/apache/maven-dependency-plugin/pull/218#discussion_r1343216254
##########
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:
##########
@@ -266,7 +267,30 @@ public abstract class AbstractAnalyzeMojo
// defaultValue value on @Parameter - not work with Maven 3.2.5
// When is set defaultValue always win, and there is no possibility to
override by plugin configuration.
@Parameter
- private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
+ private final List<String> ignoredPackagings = Arrays.asList( "pom", "ear"
);
+
+
+ /**
+ * List of dependencies to be included. The result of this list is then
applied to the ignore parameters.
Review Comment:
Decided that building sub-graphs was way to complicated, so sticking with
the original changes, which is consistent with the standard Maven filters....
[include then
exclude](https://github.com/apache/maven-common-artifact-filters/blob/9d692d49b35014a2d308c78894ee502bccd0361e/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java#L63).
##########
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:
##########
@@ -266,7 +267,30 @@ public abstract class AbstractAnalyzeMojo
// defaultValue value on @Parameter - not work with Maven 3.2.5
// When is set defaultValue always win, and there is no possibility to
override by plugin configuration.
@Parameter
- private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
+ private final List<String> ignoredPackagings = Arrays.asList( "pom", "ear"
);
+
+
+ /**
+ * List of dependencies to be included. The result of this list is then
applied to the ignore parameters.
Review Comment:
Decided that building sub-graphs was way too complicated, so sticking with
the original changes, which is consistent with the standard Maven filters....
[include then
exclude](https://github.com/apache/maven-common-artifact-filters/blob/9d692d49b35014a2d308c78894ee502bccd0361e/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java#L63).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
