[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768752#comment-17768752
]
ASF GitHub Bot commented on MNG-7864:
-------------------------------------
elharo commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1336075881
##########
Jenkinsfile.s390x.its:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+ durabilityHint('PERFORMANCE_OPTIMIZED')
+ buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+ timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+ string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+ name: 'ITS_BRANCH' )
+ }
+ stages {
+ stage("Build Maven Core") {
+ steps {
+ withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }",
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {
Review Comment:
I don't have any particular opinion about that. As long as tests are
passing, I'm OK with whatever setup works best. I just want to avoid the
situation we got into earlier where the S390x build was broken and blocking
work, and no one was addressing it. I don't think anyone here not from IBM has
the resources to debug an S390 specific problem. We have enough trouble
figuring out what's going on when a test fails only on Windows. I'm also leery
of IT failures that happen because test setup or verification isn't configured
properly for some particular platform, rather than an actual bug in the maven
product. I think we've all burned a lot of hours debugging those kinds of
"failures".
> Fix the S390x to use IT branches
> --------------------------------
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
> Reporter: Guillaume Nodet
> Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
