[
https://issues.apache.org/jira/browse/MJAVADOC-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768644#comment-17768644
]
ASF GitHub Bot commented on MJAVADOC-762:
-----------------------------------------
michael-o commented on code in PR #218:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/218#discussion_r1335746601
##########
src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java:
##########
@@ -78,27 +79,37 @@ public class JavadocReportTest extends AbstractMojoTestCase
{
public static final String OPTIONS_UMLAUT_ENCODING = "Options Umlaut
Encoding ö ä ü ß";
- /** flag to copy repo only one time */
- private static boolean TEST_REPO_CREATED = false;
-
private Path unit;
private File localRepo;
private static final Logger LOGGER =
LoggerFactory.getLogger(JavadocReportTest.class);
- /** {@inheritDoc} */
@Override
protected void setUp() throws Exception {
super.setUp();
+ Path folder = Files.createTempDirectory("JavadocReportTest");
Review Comment:
directory, not folder
> createTestRepo in JavaDocReportTest shares state
> ------------------------------------------------
>
> Key: MJAVADOC-762
> URL: https://issues.apache.org/jira/browse/MJAVADOC-762
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Assignee: Elliotte Rusty Harold
> Priority: Major
>
> This test doesn't create a new repo for every test. Therefore state is shared
> between test methods.
> Worse yet, state is shared between one run of the test suite and the next
> unless there's an intervening mvn clean.
> This caused me some very annoying debugging for a problem that I had already
> fixed but the test suite kept failing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
