[ 
https://issues.apache.org/jira/browse/MNG-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768160#comment-17768160
 ] 

ASF GitHub Bot commented on MNG-7541:
-------------------------------------

JurrianFahner commented on code in PR #878:
URL: https://github.com/apache/maven/pull/878#discussion_r1334818771


##########
apache-maven/src/assembly/maven/bin/mvnDebug.ps1:
##########
@@ -0,0 +1,42 @@
+<#
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+-----------------------------------------------------------------------------
+Apache Maven Debug Script
+
+Environment Variable Prerequisites
+
+JAVA_HOME           (Optional) Points to a Java installation.
+MAVEN_OPTS          (Optional) Java runtime options used when Maven is 
executed.
+MAVEN_SKIP_RC       (Optional) Flag to disable loading of mavenrc files.
+MAVEN_DEBUG_ADDRESS (Optional) Set the debug address. Default value is 
localhost:8000
+-----------------------------------------------------------------------------
+#>
+
+# set title
+$Host.UI.RawUI.WindowTitle = $MyInvocation.MyCommand
+
+if (-not $env:MAVEN_DEBUG_ADDRESS ) {
+  $env:MAVEN_DEBUG_ADDRESS = "8000"

Review Comment:
   But it correspond to the use in the debug string. 
   
   And with Java > 9, it is possible to specify ip and port, e.g. 8.8.8.8:8000
   Or if you want to bind to all network interfaces (which would be the same 
behavior as in java <9): *:8000
   To specify only port, will result with java > 9: 127.0.0.1:8000
   
   Luckily it is possible to override the environment variable.





> Native support for PowerShell to start Maven
> --------------------------------------------
>
>                 Key: MNG-7541
>                 URL: https://issues.apache.org/jira/browse/MNG-7541
>             Project: Maven
>          Issue Type: Improvement
>          Components: Command Line
>    Affects Versions: 3.8.3
>         Environment: windows 10 / 11
>            Reporter: Jurrian Fahner
>            Priority: Trivial
>              Labels: Script, Windows10, Windows11
>
> Maven has two files in the bin dir:
> ||command||its use||
> |mvn|POSIX shell|
> |mvn.cmd|cmd.exe|
> On windows there are two ways to write scripts, by using cmd.exe or using 
> powershell.
> If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first. 
> If it doesn't find anything it will execute `mvn.cmd` as fall-back.
> When running maven for starting a server for development purposes and you do 
> ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)?
> As far as I know it is default behaviour of cmd.exe.
> Well if I don't want to terminate, I wouldn't press ctrl-c. ;)
> It is not the case (as far as I know that Microsoft is going to deprecate 
> cmd.exe in favor of powershell: 
> [https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/]
> Allthough I think it would be a good move for maven to have also a powershell 
> script as well... It is possible to integrate elegant support for native help 
> in powershell, `get-help mvn`.
> But it also increases the maintenance effort as well. I don't know whether 
> this cost outweigh the benefits, though...
> By the way I would happy to contribute if it is appreciated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to