gnodet commented on code in PR #1244: URL: https://github.com/apache/maven/pull/1244#discussion_r1330176084
########## maven-model-builder/src/main/java/org/apache/maven/utils/Os.java: ########## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.utils; + +import java.util.Locale; +import java.util.stream.Stream; + +/** + * OS support + */ +public class Os { Review Comment: Just so I understand, why do you insist on splitting things that are clearly related to a single issue ? Is that just to slow down things and give me more work :-) ? I do agree on splitting when changes are unrelated, but here the one and only goal is to get rid of plexus-utils. Fwiw, if I can't go there for whatever reason, I'll revert all the changes as they don't make any sense to me as individual changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
