elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1324435432
########## maven-core/src/main/java/org/apache/maven/plugin/ReflectionValueExtractor.java: ########## @@ -0,0 +1,303 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugin; + +import java.lang.ref.WeakReference; +import java.lang.reflect.Array; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.util.List; +import java.util.Map; +import java.util.WeakHashMap; + +/** + * Extract values from an Object instance using simple dotted expressions + * such as <code>project.build.sourceDirectory</code> + * <p> + * The implementation supports indexed, nested and mapped properties similar to the JSP way. + * + * @see <a href= + * "http://struts.apache.org/1.x/struts-taglib/indexedprops.html";>http://struts.apache.org/1.x/struts-taglib/indexedprops.html</a> Review Comment: 404 ########## maven-model/src/test/java/org/apache/maven/model/v4/Xpp3DomPerfTest.java: ########## @@ -18,22 +18,6 @@ */ package org.apache.maven.model.v4; -/* Review Comment: I checked. This is hard violation of Apache policy. From https://www.apache.org/legal/src-headers.html Do not modify or remove any copyright notices or licenses within third-party works. Make sure that every third-party work includes its associated license, even if that requires adding a copy of the license from the third-party download site into the distribution. Do not add the standard Apache License header to the top of third-party source files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
