gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1316213195
########## maven-model-builder/src/main/java/org/apache/maven/utils/Os.java: ########## @@ -0,0 +1,383 @@ +/* Review Comment: This class is used in two cases: for profile activation and to check if the OS is windows. The second case is still correct and for the first one, I don't think anything is broken. So yes, we may not be able to detect if we're on OSX Big Sur, Monterey or whatever, but we don't need it. It solves our needs, I think it's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
