kbuntrock commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1315048042
########## src/main/java/org/apache/maven/buildcache/checksum/TreeWalkerPathMatcher.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.buildcache.checksum; + +import java.nio.file.FileSystems; +import java.nio.file.Path; +import java.nio.file.PathMatcher; + +/** + * A path matcher with some extra info + */ +public class TreeWalkerPathMatcher implements PathMatcher { + + /** + * True if the matching should stop exploring the directory tree further away + */ + private final boolean matchingSkipSubtree; + + /** + * Wrapped regular path matcher + */ + private final PathMatcher pathMatcher; Review Comment: I could use some intel about the current IT tests on different platforms and how to launch them / develop some for not yet supported platforms. And I get that it could be useful to normalize it before going through the implementation of "getPathMatcher" in order to reduce bug investigation in case of an exotic "getPathMatcher" implementation, I will think about adding this extra step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
