[ 
https://issues.apache.org/jira/browse/MRESOLVER-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750317#comment-17750317
 ] 

ASF GitHub Bot commented on MRESOLVER-387:
------------------------------------------

grgrzybek commented on PR #319:
URL: https://github.com/apache/maven-resolver/pull/319#issuecomment-1662212081

   Summarizing - this `org.eclipse.aether.supplier.RepositorySystemSupplier` is 
**very** helpful and in Camel we could use it without custom DI registry that 
handles `@Inject`.
   
   @davsclaus, I can use it when resolver 1.9.15 is out - I checked that it 
really looks like an easy update.
   
   @cstamas if there's something I could complain on... Can we have 
`org.eclipse.aether.supplier.RepositorySystemSessionSupplier` too? ;) so 
instead of:
   ```java
   RepositorySystemSupplier subject = new RepositorySystemSupplier()
   RepositorySystem system = subject.get();
   DefaultRepositorySystemSession session = 
MavenRepositorySystemUtils.newSession();
   ...
   ```
   
   we could use:
   ```java
   RepositorySystemSupplier rss = new RepositorySystemSupplier()
   RepositorySystem system = rss.get();
   RepositorySystemSupplier rsss = new RepositorySystemSessionSupplier()
   RepositorySystemSession session = rsss.get();
   ...
   ```
   
   `org.eclipse.aether.DefaultRepositorySystemSession` could be configured the 
same "override protected method" way.
   
   And entire `org.apache.maven.repository.internal.MavenRepositorySystemUtils` 
could be deprecated (instead of only 
`org.apache.maven.repository.internal.MavenRepositorySystemUtils#newServiceLocator()`).
   
   I can try preparing a PR for this if you think it's a good idea.




> Provide "static" supplier for RepositorySystem
> ----------------------------------------------
>
>                 Key: MRESOLVER-387
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-387
>             Project: Maven Resolver
>          Issue Type: Task
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.15
>
>
> To provide SL replacement.
> Something like this
> https://github.com/maveniverse/mima/blob/main/runtime/standalone-static/src/main/java/eu/maveniverse/maven/mima/runtime/standalonestatic/RepositorySystemSupplier.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to