[ 
https://issues.apache.org/jira/browse/MWAR-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750194#comment-17750194
 ] 
ASF GitHub Bot commented on MWAR-470:
-------------------------------------

frode-carlsen opened a new pull request, #55:
URL: https://github.com/apache/maven-war-plugin/pull/55

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MWAR) filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [X] Each commit in the pull request should have a meaningful subject line 
and body.
    - [X] Format the pull request title like `[MWAR-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `MWAR-XXX` with the appropriate JIRA issue. Best 
practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [X] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Support user property for packagingExcludes
> -------------------------------------------
>
>                 Key: MWAR-470
>                 URL: https://issues.apache.org/jira/browse/MWAR-470
>             Project: Maven WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.4.0
>            Reporter: F Carlsen
>            Priority: Major
>
> Supporting a user property for packagingExcludes (for example 
> 'maven.war.packagingExcludes') would be most welcome.  The use case is 
> building multiple microservices in standardized CICD pipelines where some 
> artifacts must be ignored because they are installed by the environment the 
> final artefact will run in, but not to be ignored when 
> building/testing/developing locally or perhaps in some build stages.
> A common alternative would  be to use an optional maven profile with the 
> packagingExcludes, excluding the artefacts upon activation in the CICD 
> pipeline, but for dozens of microservices this leads to a lot of duplication 
> or inheritance of profiles (which is a bad practice, since they can't truly 
> be overridden in maven) 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to