[ 
https://issues.apache.org/jira/browse/SCM-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744926#comment-17744926
 ] 

ASF GitHub Bot commented on SCM-1011:
-------------------------------------

kwin commented on code in PR #181:
URL: https://github.com/apache/maven-scm/pull/181#discussion_r1269056701


##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/checkin/SvnCheckInCommand.java:
##########
@@ -104,7 +110,13 @@ protected CheckInScmResult executeCheckInCommand(
 
     public static Commandline createCommandLine(

Review Comment:
   Do we consider this public API, i.e. is overloading necessary here or can I 
just change the signature of the existing method?





> Do not set --non-interactive for SVN provider by default
> --------------------------------------------------------
>
>                 Key: SCM-1011
>                 URL: https://issues.apache.org/jira/browse/SCM-1011
>             Project: Maven SCM
>          Issue Type: Improvement
>          Components: maven-scm-provider-svn
>            Reporter: Konrad Windszus
>            Priority: Major
>
> For historical reasons the SVN commands were always called with option 
> {{--non-interactive}} 
> (https://github.com/apache/maven-scm/commit/f079a27b52dc243cd4731c1b68c8d714f9aa3829#diff-a51b4af351fd8bb911bf50a382255bdf1236a5b8d634ab09acb019247c917ae3R62).
>  Although this became configurable with SCM-402 the default always stayed the 
> same.
> Now that https://issues.apache.org/jira/browse/MSHARED-1072 is fixed, I would 
> propose to leave out the flag by default in order to allow for interactive 
> prompts if Maven is executed in interactive mode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to