elharo commented on code in PR #203:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/203#discussion_r1248765447
##########
pom.xml:
##########
@@ -380,6 +380,16 @@ under the License.
<version>${slf4jVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven.plugins</groupId>
Review Comment:
indentation is off
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java:
##########
@@ -873,19 +876,11 @@ private ClassLoader getProjectClassLoader() throws
MojoExecutionException {
* @param javaClass not null
* @throws IOException if any
* @throws MojoExecutionException if any
+ *
*/
- private void processFix(JavaClass javaClass) throws IOException,
MojoExecutionException {
- // Skipping inner classes
- if (javaClass.isInner()) {
- return;
- }
-
- File javaFile;
- try {
- javaFile =
Paths.get(javaClass.getSource().getURL().toURI()).toFile();
- } catch (URISyntaxException e) {
- throw new MojoExecutionException(e.getMessage());
- }
+ // Refactoring : Extract Method
Review Comment:
needless comment
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java:
##########
@@ -1205,11 +1227,23 @@ private boolean fixFieldComment(
* <font color="#2a00ff">"value"</font><font
color="#000000">;</font>
* </code>
*
- * @param stringWriter not null
- * @param field not null
- * @param indent not null
+// * @param stringWriter not null
Review Comment:
why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
