[
http://jira.codehaus.org/browse/NMAVEN-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100039
]
Brian Deacon commented on NMAVEN-79:
------------------------------------
It occurs to me that since that hunt now involves actually looking at the file
system, and so involves some minimal IO, that we might want to have that
GetSettingsFilePath done only once as a static class initializer and then just
returned from a static variable... but I don't imagine the hit is much of a big
deal.
Or even just change it to a public static property "SettingsFilePath" that
returns the full path to nmaven-settings.xml, and that could become the
authoritative source for getting the file name, and we could stop having ".m2"
and "nmaven-settings.xml" sprinkled around as literals throughout the code.
> With <vendor>MICROSOFT</vendor> still failing with "NMAVEN-9011-007: Mono
> installation could not be found."
> -----------------------------------------------------------------------------------------------------------
>
> Key: NMAVEN-79
> URL: http://jira.codehaus.org/browse/NMAVEN-79
> Project: NMaven
> Issue Type: Bug
> Environment: ALLUSERSPROFILE=C:\Documents and Settings\All Users
> APPDATA=C:\Documents and Settings\bdeacon\Application Data
> ASMROOT=C:\TNGSD\SD
> CLASSPATH=.;C:\Program Files\Java\jre1.5.0_11\lib\ext\QTJava.zip
> CLIENTNAME=Console
> CommonProgramFiles=C:\Program Files\Common Files
> COMPUTERNAME=SDGD04202608
> ComSpec=C:\WINDOWS\system32\cmd.exe
> CVSROOT=:pserver:[EMAIL PROTECTED]:/v/releng/cvsroot
> ERROR_CODE=1
> FP_NO_HOST_CHECK=NO
> HOMEDRIVE=H:
> HOMEPATH=\
> HOMESHARE=\\sdgfs01\users\bdeacon
> Intuit=1
> JAVA_HOME=C:\Program Files\Java\jdk1.5.0_12
> LOGONSERVER=\\SDGDCCORP04
> M2_HOME=C:\Program Files\Apache Software Foundation\maven-2.0.6
> MAVEN_HOME=C:\Program Files\Apache Software Foundation\Maven 1.0.2
> MSILIB=\\SDPSDO05\MSILIB
> NUMBER_OF_PROCESSORS=2
> OS=Windows_NT
> Path=C:\Program
> Files\Java\jdk1.5.0_12\bin;C:\Perl\bin\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\Downloaded
> Program Files;C:\Program Files\Common Files\Roxio
> Shared\DLLShared;C:\TNGSD\BIN;c:\Program Files\Microsoft SQL
> Server\90\Tools\binn\;C:\utils\bin;C:\Program Files\Apache Software
> Foundation\Maven 1.0.2\bin;C:\Program Files\Apache Software
> Foundation\maven-2.0.6\bin;C:\Program Files\cvsnt;C:\Program
> Files\Perforce;C:\Program Files\IDM Computer
> Solutions\UltraEdit-32;C:\mysql5\bin;C:\ruby\bin;C:\Program
> Files\QuickTime\QTSystem\
> PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH
> PROCESSOR_ARCHITECTURE=x86
> PROCESSOR_IDENTIFIER=x86 Family 15 Model 4 Stepping 1, GenuineIntel
> PROCESSOR_LEVEL=15
> PROCESSOR_REVISION=0401
> ProgramFiles=C:\Program Files
> PROMPT=$P$G
> QTJAVA=C:\Program Files\Java\jre1.5.0_11\lib\ext\QTJava.zip
> RUBYOPT=rubygems
> RUBY_HOME=C:\ruby
> SESSIONNAME=Console
> SystemDrive=C:
> SystemRoot=C:\WINDOWS
> TEMP=C:\TEMP
> TMP=C:\TEMP
> USERDNSDOMAIN=CORP.INTUIT.NET
> USERDOMAIN=CORP
> USERNAME=bdeacon
> USERPROFILE=C:\Documents and Settings\bdeacon
> VS80COMNTOOLS=C:\Program Files\Microsoft Visual Studio 8\Common7\Tools\
> windir=C:\WINDOWS
> Reporter: Brian Deacon
> Attachments: build.log, pom.xml, SettingsGeneratorMojo.diff,
> SettingsGeneratorMojo.diff
>
>
> Pom and log output attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
