[
https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738113#comment-17738113
]
ASF GitHub Bot commented on MNG-7830:
-------------------------------------
gnodet commented on PR #1185:
URL: https://github.com/apache/maven/pull/1185#issuecomment-1611403721
> Wow. This looks great. definitely a big leap forward.
>
> I might have missed it, but I didn't find any explicit use of the Stax2
API or Woodstox classes. Could this be done with JDK classes only? classes?
Stax2 / woodstox is actually needed for the consumer POM transformation: the
stax api is not sufficient and does not allow full round tripping with xml as
spaces in prolog are not reported. Even aalto-xml does not support it. The
effect is that when using another implementation, the line breaks before the
first element of the POM are removed, so the generated POM will usually
contains the xml declaration, the license and the `<project>` element on a
single line. Most importantly, this breaks tests :-)
Apart from this use case, changing the implementation leads to various small
issues as they do sometimes slightly differ in the specific events they
generate. Writing namespaces is particularly challenging, though there's
certainly a way to solve those discrepancies, but again, it breaks a few ITs
which are particularly sensitive to the exact XML generated.
Also, woodstox is 50% faster than the JDK implementation, so I definitely
think we should use it.
> Switch from plexus-xml to stax / woodstox
> -----------------------------------------
>
> Key: MNG-7830
> URL: https://issues.apache.org/jira/browse/MNG-7830
> Project: Maven
> Issue Type: Dependency upgrade
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
