[
https://issues.apache.org/jira/browse/MSHARED-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735903#comment-17735903
]
ASF GitHub Bot commented on MSHARED-1275:
-----------------------------------------
michael-o opened a new pull request, #21:
URL: https://github.com/apache/maven-reporting-impl/pull/21
This closes #21
> MavenReport#canGenerateReport() is invoked twice
> ------------------------------------------------
>
> Key: MSHARED-1275
> URL: https://issues.apache.org/jira/browse/MSHARED-1275
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-reporting-impl
> Affects Versions: maven-reporting-impl-4.0.0-M8
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M9
>
>
> The mentioned method called twice for standalone **and** Maven Site Plugin
> use case in {{org.apache.maven.reporting.AbstractMavenReport.generate(Sink,
> SinkFactory, Locale)}} also both uses cases make sure that
> {{canGenerateReport()}} is invoked *before* {{generate()}} is invoked. This
> is clearly redudant and can incur a performance overhead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
