gnodet commented on code in PR #301:
URL: https://github.com/apache/maven-resolver/pull/301#discussion_r1234820922
##########
maven-resolver-named-locks-hazelcast/src/test/java/org/eclipse/aether/named/hazelcast/NamedLockFactoryAdapterTestSupport.java:
##########
@@ -230,7 +231,7 @@ public void run() {
chained.run();
}
loser.await();
- } catch (IllegalStateException e) {
+ } catch (IllegalStateException |
LockUpgradeNotSupportedException e) {
loser.countDown();
Review Comment:
The previous statement does print something, that one should be coherent
imho.
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/synccontext/NamedLockFactoryAdapterTestSupport.java:
##########
@@ -266,7 +267,7 @@ public void run() {
chained.run();
}
loser.await();
- } catch (IllegalStateException e) {
+ } catch (IllegalStateException |
LockUpgradeNotSupportedException e) {
e.printStackTrace(); // for ref purposes
Review Comment:
I know this is unrelated, but we could use a logger instead of stderr or
just remove this statement or make it conditional ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
